Add support for SNS topics #1952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,104 @@ | |||
| package aws | |||
There was a problem hiding this comment.
I'm not sure this file should be actually called resource_ since it's not really a resource with its own schema.
There was a problem hiding this comment.
Fair enough. Easy fix. One moment.
This is a cut and dry resource addition with one exception: There's no way to describe or filter for a single topic in the AWS API. Callers must paginate their response every 100 topics, and match on a known ARN. So, implement an SNS topic seeker. This is a fairly simple state machine based on Rob Pike's "Lexical Scanning in Go" presentation: http://cuddle.googlecode.com/hg/talk/lex.html#title-slide
ctiwald
force-pushed
the
ct/add-sns-topics
branch
from
822e279
to
e23862a
Compare
|
Self-closing this in favor of #1974. It adds more support and uses a GetTopicAttributes call I wasn't aware of to better flesh out the topic's computed properties. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chips away at #28. This would have been the simplest thing in the world to do were it not for one, uh, feature of the SNS API. There is no way to describe or filter for an individual topic.
Instead, you have to page results back from a complete topic list, and unlike autoscaling groups (whose paging limit is something like 1600), the paging limit for SNS topics is 100. I didn't feel right not supporting result paging here; it's entirely possible a TF user could have more than 100 SNS topics if they really love the product, so I wrote a pager.
The file is
sns_topic_seeker.goand implements a basic state machine whose design will look mighty familiar if you've ever seen this presentation by Rob Pike or read the source code totext/template/parse/lex.goin the stdlib. It's basically a slimmed down implementation of the same pattern, and I've covered it with a bunch of unit tests to make sure it works and works well.For what it's worth, I think it could be abstracted to an interface and used to "page" anything in AWS that returns a
NextToken, but I didn't want to build a generalized version if this is the only AWS resource that'll use it.Anyway, let me know if there are any problems here. I'm going to add SNS topic support to AS groups too per #1419, but that file's a bit complex and I didn't feel like biting it off quite yet. I need it though so I'll try to finish it off later this week.